Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spelling mistake and rewording #196

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

AWS-Joe-A
Copy link
Contributor

Issue #, if available:
n/a

Description of changes:

  1. Updated the text Conformation to CloudFormation in https://aws-observability.github.io/observability-best-practices/guides/cost/cost-visualization/amazon-prometheus on line 7

  2. Updated Pros and Cons > Advantages for "Configuring High-Availability is a challenge","Too many copies of Collector in use", and "Too many copies of Collector in use" to sound more positive in https://aws-observability.github.io/observability-best-practices/guides/operational/adot-at-scale/operating-adot-collector between line 80-83

From:

  • Minimal scaling concerns
  • Configuring High-Availability is a challenge
  • Too many copies of Collector in use
  • Can be easy for Logs support

To:

  • Minimal scaling concerns
  • High availability configuration options
  • Flexibility in Collector deployment
  • Simplified log support process

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

  1. Updated the text **Conformation** to **CloudFormation** in https://aws-observability.github.io/observability-best-practices/guides/cost/cost-visualization/amazon-prometheus on line 7

  2. Updated Pros and Cons > Advantages for "Configuring High-Availability is a challenge","Too many copies of Collector in use", and "Too many copies of Collector in use" to sound more positive in https://aws-observability.github.io/observability-best-practices/guides/operational/adot-at-scale/operating-adot-collector between line 80-83
@sguruvar sguruvar self-requested a review December 18, 2024 01:47
Copy link
Contributor

@sguruvar sguruvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sguruvar sguruvar merged commit 5c7b665 into aws-observability:main Dec 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants