Migrate Windows helm-chart tests. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving over to make new PR.
sethAmazon
reviewed
May 1, 2024
| @@ -1,6 +1,9 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| //go:build linuxonly || windowslinux | |||
There was a problem hiding this comment.
Not sure, but this is how it was in the previous package I migrated from: https://github.com/aws/amazon-cloudwatch-agent-operator/blob/cab619e55a8719dbfcf7756d0e1647f9d7834521/integration-tests/eks/validateResources_test.go#L4.
I know it was in the other packages to associate tags with it.
There was a problem hiding this comment.
Yeah that's needed coz those tags are used to distinguish linux/windows integration tests
sethAmazon
approved these changes
May 1, 2024
mitali-salvi
approved these changes
May 1, 2024
mitali-salvi
pushed a commit
that referenced
this pull request
May 8, 2024
Migrate Windows helm-chart tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated windows from https://github.com/aws/amazon-cloudwatch-agent-operator/blob/main/.github/workflows/helm-integ-test.yml into https://github.com/aws-observability/helm-charts/blob/main/.github/workflows/amazon-cloudwatch-observability-helm-integration-test.yaml and refactored the directory location for helm.
See #27 for previous status on PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.