Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sessionLimitOverride always record by type #505

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

williazz
Copy link
Contributor

@williazz williazz commented Feb 8, 2024

Purpose

If merged, RUM users can use the below example to bypass sessionEventLimit and record whatever events they need. However, this PR is limited to "always record" configuration and does not support specific limits, which would need us to migrate event counts from cookies to localStorage to avoid pollution.

const config: AwsRumConfig = {
    ...
    sessionEventLimitOverride: {
        'com.amazonaws.rum.http_event': 0, // always record
        'custom_type': 1 // non-zero limits are not supported in this PR, and will be handled by sessionEventLimit
    }
}

Documentation updates will be addressed in a separate PR.

Depends on

#504


Engineering plan for #480 summarized here #480 (comment)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@williazz williazz changed the title feat: add SessionEventLimit override support for always record feat: add sessionLimitOverride support to always record certain types Feb 8, 2024
@williazz williazz changed the title feat: add sessionLimitOverride support to always record certain types feat: add sessionLimitOverride always record by type Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant