Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarball Fix: Include json files from build directory for npm pack #35

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Aug 28, 2024

Issue #, if available:

  • json file was missing in tarball generated by npm pack

Description of changes:

Testing
Verified that package/build/src/configuration/sql_dialect_keywords.json is now present in tarball:

tar -xvzf aws-aws-distro-opentelemetry-node-autoinstrumentation-0.0.1.tgz 
x package/LICENSE
x package/build/src/always-record-sampler.js
x package/build/src/attribute-propagating-span-processor-builder.js
x package/build/src/attribute-propagating-span-processor.js
x package/build/src/aws-attribute-keys.js
x package/build/src/aws-metric-attribute-generator.js
x package/build/src/aws-metric-attributes-span-exporter-builder.js
x package/build/src/aws-metric-attributes-span-exporter.js
x package/build/src/aws-opentelemetry-configurator.js
x package/build/src/aws-span-metrics-processor-builder.js
x package/build/src/aws-span-metrics-processor.js
x package/build/src/aws-span-processing-util.js
x package/build/src/sampler/aws-xray-remote-sampler.js
x package/build/src/sampler/aws-xray-sampling-client.js
x package/build/src/sampler/fallback-sampler.js
x package/build/src/patches/instrumentation-patch.js
x package/build/src/patches/aws/services/kinesis.js
x package/build/src/metric-attribute-generator.js
x package/build/src/sampler/rate-limiter.js
x package/build/src/sampler/rate-limiting-sampler.js
x package/build/src/register.js
x package/build/src/sampler/remote-sampler.types.js
x package/build/src/sampler/rule-cache.js
x package/build/src/patches/aws/services/s3.js
x package/build/src/sampler/sampling-rule-applier.js
x package/build/src/sampler/sampling-rule.js
x package/build/src/third-party/otel/aws/services/ServiceExtension.js
x package/build/src/sqs-url-parser.js
x package/build/src/sampler/statistics.js
x package/build/src/sampler/utils.js
x package/build/src/version.js
x package/package.json
x package/build/src/configuration/sql_dialect_keywords.json
x package/build/src/always-record-sampler.js.map
x package/build/src/attribute-propagating-span-processor-builder.js.map
x package/build/src/attribute-propagating-span-processor.js.map
x package/build/src/aws-attribute-keys.js.map
x package/build/src/aws-metric-attribute-generator.js.map
x package/build/src/aws-metric-attributes-span-exporter-builder.js.map
x package/build/src/aws-metric-attributes-span-exporter.js.map
x package/build/src/aws-opentelemetry-configurator.js.map
x package/build/src/aws-span-metrics-processor-builder.js.map
x package/build/src/aws-span-metrics-processor.js.map
x package/build/src/aws-span-processing-util.js.map
x package/build/src/sampler/aws-xray-remote-sampler.js.map
x package/build/src/sampler/aws-xray-sampling-client.js.map
x package/build/src/sampler/fallback-sampler.js.map
x package/build/src/patches/instrumentation-patch.js.map
x package/build/src/patches/aws/services/kinesis.js.map
x package/build/src/metric-attribute-generator.js.map
x package/build/src/sampler/rate-limiter.js.map
x package/build/src/sampler/rate-limiting-sampler.js.map
x package/build/src/register.js.map
x package/build/src/sampler/remote-sampler.types.js.map
x package/build/src/sampler/rule-cache.js.map
x package/build/src/patches/aws/services/s3.js.map
x package/build/src/sampler/sampling-rule-applier.js.map
x package/build/src/sampler/sampling-rule.js.map
x package/build/src/third-party/otel/aws/services/ServiceExtension.js.map
x package/build/src/sqs-url-parser.js.map
x package/build/src/sampler/statistics.js.map
x package/build/src/sampler/utils.js.map
x package/build/src/version.js.map
x package/README.md
x package/build/src/always-record-sampler.d.ts
x package/build/src/attribute-propagating-span-processor-builder.d.ts
x package/build/src/attribute-propagating-span-processor.d.ts
x package/build/src/aws-attribute-keys.d.ts
x package/build/src/aws-metric-attribute-generator.d.ts
x package/build/src/aws-metric-attributes-span-exporter-builder.d.ts
x package/build/src/aws-metric-attributes-span-exporter.d.ts
x package/build/src/aws-opentelemetry-configurator.d.ts
x package/build/src/aws-span-metrics-processor-builder.d.ts
x package/build/src/aws-span-metrics-processor.d.ts
x package/build/src/aws-span-processing-util.d.ts
x package/build/src/sampler/aws-xray-remote-sampler.d.ts
x package/build/src/sampler/aws-xray-sampling-client.d.ts
x package/build/src/sampler/fallback-sampler.d.ts
x package/build/src/patches/instrumentation-patch.d.ts
x package/build/src/patches/aws/services/kinesis.d.ts
x package/build/src/metric-attribute-generator.d.ts
x package/build/src/sampler/rate-limiter.d.ts
x package/build/src/sampler/rate-limiting-sampler.d.ts
x package/build/src/register.d.ts
x package/build/src/sampler/remote-sampler.types.d.ts
x package/build/src/sampler/rule-cache.d.ts
x package/build/src/patches/aws/services/s3.d.ts
x package/build/src/sampler/sampling-rule-applier.d.ts
x package/build/src/sampler/sampling-rule.d.ts
x package/build/src/third-party/otel/aws/services/ServiceExtension.d.ts
x package/build/src/sqs-url-parser.d.ts
x package/build/src/sampler/statistics.d.ts
x package/build/src/sampler/utils.d.ts
x package/build/src/version.d.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from majanjua-amzn August 28, 2024 17:02
@jj22ee jj22ee requested a review from a team as a code owner August 28, 2024 17:02
@jj22ee jj22ee merged commit 98d5f83 into main Aug 28, 2024
6 checks passed
@jj22ee jj22ee deleted the include-json-files branch August 28, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants