-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Patching Mechanism with AWS SDK telemetry improvements #13
Conversation
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-attribute-keys.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-metric-attribute-generator.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/register.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/index.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/kinesis.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/kinesis.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/kinesis.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/aws/services/kinesis.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/patches/instrumentation-patch.test.ts
Show resolved
Hide resolved
Need more testing done - show that this works by generating spans & metrics that have the attributes in question please. |
Added "integration/contract test" to test patched |
aws-distro-opentelemetry-node-autoinstrumentation/src/aws-attribute-keys.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/aws-opentelemetry-configurator.test.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/src/patches/instrumentation-patch.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/register.patch.test.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/test-app/app-aws-sdk-kinesis-call.js
Outdated
Show resolved
Hide resolved
See my comment on integ tests - I'm not crazy about having them. I was really more referring to manual test results, though yes, they are sufficient for addressing my earlier comment. |
aws-distro-opentelemetry-node-autoinstrumentation/test/patches/instrumentation-patch.test.ts
Outdated
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/patches/instrumentation-patch.test.ts
Show resolved
Hide resolved
aws-distro-opentelemetry-node-autoinstrumentation/test/register.patch.test.ts
Outdated
Show resolved
Hide resolved
*Issue #, if available:* See context in: #13 (comment) The `register.patch.test.ts` is being removed in favor of the existing contract tests for AWS SDK patches. *Description of changes:* Remove `register.patch.test.ts` and associated resources. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Issue #, if available:
Description of changes:
aws-attribute-keys.ts
:AWS_BUCKET_NAME, AWS_QUEUE_URL, AWS_QUEUE_NAME, AWS_STREAM_NAME, AWS_TABLE_NAME
in order to match the actual attribute collected from AWS SDK auto-instrumentationaws-metric-attribute-generator.ts
:aws-opentelemetry-configurator.ts
:instrumentation-patch.ts
:register.ts
:AWS_APPLY_PATCHES
env var is not'true'
The following files are copied from upstream:
The following files are being contributed to upstream:
See: open-telemetry/opentelemetry-js-contrib#2361
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.