Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable smoke test controller telemetry. #985

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

zzhlogin
Copy link
Contributor

Description of changes:
Previously, in v1.x, the springboot controller telemetry data is enabled by default.

Starting from upstream v2.x, the controller telemetry need to be enable by setting up env OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED: https://opentelemetry.io/docs/zero-code/java/agent/disable/#suppressing-controller-andor-view-spans.

This PR enable the telemetry data to align with smoke test validator.
https://opentelemetry.io/docs/zero-code/java/agent/disable/#suppressing-controller-andor-view-spans

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zzhlogin zzhlogin requested a review from a team as a code owner December 24, 2024 19:40
@zzhlogin zzhlogin merged commit 2c22ba5 into aws-observability:main Dec 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants