Use grpc exporter for agent test workflow. #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain why do we need to explicitly export using grpc and not the default http? |
Previously, in v1.x, the default protocol is grpc, and the smoke tests is using the default protocol here. Starting from upstream v2.x, the default OTLP protocol has been changed from grpc to http/protobuf (release note). So that we need to specifically set the protocol using env |
|
Thanks. It makes sense now. :) |
srprash
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add
OTEL_EXPORTER_OTLP_PROTOCOLtogrpcfor instrumentation as in version v2.0.0:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.