Use input rather than secret (#702)

aws-observability · Jan 9, 2024 · 2f29ec1 · 2f29ec1
1 parent a1722da
commit 2f29ec1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/.github/actions/cpUtility-testing/action.yml b/.github/actions/cpUtility-testing/action.yml
@@ -16,6 +16,10 @@ inputs:
   adot-java-version:
     required: true
     description: "ADOT Java Version"
+  snapshot-ecr-role:
+    require: true
+    description: "IAM Role used for pushing to snapshot ecr"
+
 
 runs:
   using: "composite"
@@ -29,7 +33,7 @@ runs:
     - name: Configure AWS Credentials
       uses: aws-actions/configure-aws-credentials@v4
       with:
-        role-to-assume: ${{ secrets.JAVA_INSTRUMENTATION_SNAPSHOT_ECR }}
+        role-to-assume: ${{ inputs.snapshot-ecr-role }}
         aws-region: ${{ inputs.aws-region }}
 
     - name: Login to private staging ecr

diff --git a/.github/workflows/main-build.yml b/.github/workflows/main-build.yml
@@ -126,6 +126,7 @@ jobs:
           image_uri_with_tag: ${{ steps.imageOutput.outputs.stagingImage }}
           image_registry: ${{ steps.imageOutput.outputs.stagingRegistry }}
           adot-java-version: ${{ steps.getADOTJavaVersion.outputs.adot_java_version }}
+          snapshot-ecr-role: ${{ secrets.JAVA_INSTRUMENTATION_SNAPSHOT_ECR }}
 
       - name: Upload to GitHub Actions
         uses: actions/upload-artifact@v3

diff --git a/.github/workflows/nightly-upstream-snapshot-build.yml b/.github/workflows/nightly-upstream-snapshot-build.yml
@@ -78,6 +78,7 @@ jobs:
           image_uri_with_tag: ${{ steps.imageOutput.outputs.rcImage }}
           image_registry: ${{ steps.imageOutput.outputs.imageRegistry }}
           adot-java-version: ${{ steps.getADOTJavaVersion.outputs.adot_java_version }}
+          snapshot-ecr-role: ${{ secrets.JAVA_INSTRUMENTATION_SNAPSHOT_ECR }}
 
       - name: Upload to GitHub Actions
         uses: actions/upload-artifact@v3