Skip to content

Commit

Permalink
Merge pull request #748 from humivo/FixJava
Browse files Browse the repository at this point in the history
Fix java dependency updates
  • Loading branch information
humivo authored Oct 12, 2023
2 parents 1e434bb + c975575 commit 9bed4de
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import io.opentelemetry.sdk.trace.SdkTracerProvider;
import java.time.Duration;

import static io.opentelemetry.semconv.resource.attributes.ResourceAttributes.SERVICE_NAME;
import io.opentelemetry.semconv.ResourceAttributes;

import org.springframework.stereotype.Controller;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -36,7 +36,7 @@ public class AppController {
}

Resource resource = Resource.builder()
.put(SERVICE_NAME, serviceName)
.put(ResourceAttributes.SERVICE_NAME, serviceName)
.build();

OpenTelemetry openTelemetry =
Expand Down
2 changes: 1 addition & 1 deletion sample-apps/java-sample-app/manual/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jib {
dependencies {

// OpenTelemetry APIs and SDKs
implementation(platform("io.opentelemetry:opentelemetry-bom:1.31.0"))
implementation(platform("io.opentelemetry:opentelemetry-bom:1.30.1"))
implementation("io.opentelemetry:opentelemetry-api")
implementation("io.opentelemetry:opentelemetry-sdk")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@
import software.amazon.awssdk.services.s3.S3Client;
import spark.Response;

import java.util.List;

public class ManualApp extends BaseApp {

private static final String REQUEST_OTEL_SCOPE = "requestOtelContext";
Expand Down

0 comments on commit 9bed4de

Please sign in to comment.