Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Manifest Tests Failing on Redis Image #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ollypom
Copy link

@ollypom ollypom commented Feb 12, 2024

Related Issue

TestHeadManifest and TestGetManifest were failing as the upstream public.ecr.aws/docker/library/redis:7 have switched from Docker Manifest Lists to OCI Image Indexes.

$ crane manifest public.ecr.aws/docker/library/redis:7 | jq -r '.mediaType'
application/vnd.oci.image.index.v1+json

See failing tests:

=== RUN   TestGetManifest
{"level":"info","RequestId":"abcd-1234-test-get-manifest","time":"2024-02-12T12:00:44Z","message":"Initializing registry client"}
    registry_test.go:76: Incorrect manifest media type. Expected application/vnd.docker.distribution.manifest.list.v2+json but got application/vnd.oci.image.index.v1+json
--- FAIL: TestGetManifest (0.37s)

Proposed Changes

Added a new constant for the Image Index and updated the tests. I have validated locally with make test.

Reviewers

Please tag the person or team responsible for reviewing this pull request, using the @ symbol followed by their username.

@ollypom ollypom requested a review from a team as a code owner February 12, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants