Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): use correct listLocation attribute names in Storage Browser auth example #6264

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

tiffanynwyeung
Copy link
Contributor

Description of changes

Fix Storage Browser docs example where "Customer Managed Auth" section uses incorrect listLocations attribute names.

Issue #, if available

Description of how you validated changes

local docs, comparison against stobro types

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tiffanynwyeung tiffanynwyeung requested a review from a team as a code owner December 19, 2024 18:10
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 8279d9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@jordanvn jordanvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed this aligns with the ListLocations interface

@tiffanynwyeung tiffanynwyeung merged commit b1a45b9 into main Dec 19, 2024
34 checks passed
@tiffanynwyeung tiffanynwyeung deleted the docs/fix-stobro-auth-attr branch December 19, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants