-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authenticator): email mfa #6257
base: feat-email-mfa/main
Are you sure you want to change the base?
Conversation
|
type MfaType = 'EMAIL' | 'wow'; | ||
*/ | ||
|
||
const generateRadioGroup = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have one of the radio options selected by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or make sure the continue button is disabled until one is selected.
@@ -147,6 +149,10 @@ export type SignInStep = | |||
| 'CONFIRM_SIGN_UP' | |||
| 'CONTINUE_SIGN_IN_WITH_TOTP_SETUP' | |||
| 'RESET_PASSWORD' | |||
| 'CONTINUE_SIGN_IN_WITH_MFA_SETUP_SELECTION' | |||
| 'CONTINUE_SIGN_IN_WITH_EMAIL_MFA_SETUP' // 'CONTINUE_SIGN_IN_WITH_EMAIL_SETUP' in js library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for deviating from the JS sign in steps?
: undefined; | ||
}, | ||
}); | ||
|
||
const clearAllowedMFATypes = assign({ allowedMFATypes: {} }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use []
here to keep the types consistent? or just undefined
?
type MfaType = 'EMAIL' | 'wow'; | ||
*/ | ||
|
||
const generateRadioGroup = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or make sure the continue button is disabled until one is selected.
Moving fork branch into feature branch.
Description of changes
PR to add email MFA. User flows will have MFA selection if multiple MFA methods are available, setup for email MFA if need be, and confirmation of sign in with a code sent to user's email.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.