Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authenticator): email mfa #6257

Draft
wants to merge 6 commits into
base: feat-email-mfa/main
Choose a base branch
from

Conversation

scanlonp
Copy link

@scanlonp scanlonp commented Dec 17, 2024

Moving fork branch into feature branch.

Description of changes

PR to add email MFA. User flows will have MFA selection if multiple MFA methods are available, setup for email MFA if need be, and confirmation of sign in with a code sent to user's email.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 1eb6032

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@scanlonp scanlonp changed the title Email mfa temp feat(authenticator): email mfa Dec 17, 2024
@scanlonp scanlonp changed the base branch from main to feat-email-mfa/main December 18, 2024 16:43
type MfaType = 'EMAIL' | 'wow';
*/

const generateRadioGroup = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have one of the radio options selected by default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or make sure the continue button is disabled until one is selected.

@@ -147,6 +149,10 @@ export type SignInStep =
| 'CONFIRM_SIGN_UP'
| 'CONTINUE_SIGN_IN_WITH_TOTP_SETUP'
| 'RESET_PASSWORD'
| 'CONTINUE_SIGN_IN_WITH_MFA_SETUP_SELECTION'
| 'CONTINUE_SIGN_IN_WITH_EMAIL_MFA_SETUP' // 'CONTINUE_SIGN_IN_WITH_EMAIL_SETUP' in js library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for deviating from the JS sign in steps?

: undefined;
},
});

const clearAllowedMFATypes = assign({ allowedMFATypes: {} });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use [] here to keep the types consistent? or just undefined?

type MfaType = 'EMAIL' | 'wow';
*/

const generateRadioGroup = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or make sure the continue button is disabled until one is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants