Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage-browser) Shore up action handler unit tests #6207

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

cshfang
Copy link
Member

@cshfang cshfang commented Nov 25, 2024

Description of changes

This PR improves test coverage of action handlers. Also adds tests for related utils and converts spies into mocks so tests are not inadvertently calling the underlying library implementations.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cshfang cshfang requested a review from a team as a code owner November 25, 2024 22:44
Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: f6adcf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cshfang cshfang merged commit 4279e9f into main Nov 27, 2024
34 checks passed
@cshfang cshfang deleted the test/action-handlers branch November 27, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants