Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signout bug when offline #6061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dehli
Copy link
Contributor

@dehli dehli commented Nov 12, 2024

Description of changes

If you call Auth.fetchAuthSession({ forceRefresh: true }) while offline and using the Authenticator, amplify-ui will trigger the logout flow. This fixes that bug.

Issue #6057, if available

Description of how you validated changes

Added a test and used patch-package.

This is the related amplify-js code:

https://github.com/aws-amplify/amplify-js/blob/0f5091780046b9556b98300c29fb970a0358bd70/packages/auth/src/providers/cognito/tokenProvider/TokenOrchestrator.ts#L173-L176

image

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added (when running locally they seem to run infinitely but I did add a test)
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dehli dehli requested a review from a team as a code owner November 12, 2024 10:50
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 5051b6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dehli dehli force-pushed the dev/dehli/fix-6057 branch from c378277 to 5051b6e Compare November 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant