Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-storage): refactor Title (rebased) #6013

Closed
wants to merge 32 commits into from
Closed

chore(react-storage): refactor Title (rebased) #6013

wants to merge 32 commits into from

Conversation

joon-won
Copy link
Member

@joon-won joon-won commented Nov 5, 2024

Description of changes

  • Add Title composable component and corresponding control (TitleControl), hook (useTitle)
  • Add corresponding unit tests for each of them

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joon-won joon-won requested a review from a team as a code owner November 5, 2024 23:30
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a1a43e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joon-won joon-won mentioned this pull request Nov 5, 2024
Closed
5 tasks
Samaritan1011001
Samaritan1011001 reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@Samaritan1011001 Samaritan1011001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just wondering where the usage of TitleControl is and if that needs to be updated as well, otherwise it looks good to me.

packages/react-storage/src/components/StorageBrowser/controls/__tests__/TitleControl.spec.tsx Outdated Show resolved Hide resolved
@joon-won joon-won requested a review from cshfang November 6, 2024 19:55
ashwinkumar6
ashwinkumar6 reviewed Nov 6, 2024
View reviewed changes
packages/react-storage/src/components/StorageBrowser/controls/hooks/useTitle.tsx Outdated Show resolved Hide resolved
packages/react-storage/src/components/StorageBrowser/controls/hooks/__tests__/useTitle.spec.tsx Outdated Show resolved Hide resolved
packages/react-storage/src/components/StorageBrowser/controls/hooks/__tests__/useTitle.spec.tsx Outdated Show resolved Hide resolved
packages/react-storage/src/components/StorageBrowser/controls/hooks/__tests__/useTitle.spec.tsx Outdated Show resolved Hide resolved
...react-storage/src/components/StorageBrowser/views/LocationActionView/DeleteFilesControls.tsx Outdated Show resolved Hide resolved
packages/react-storage/src/components/StorageBrowser/views/LocationDetailView/Controls.tsx Outdated Show resolved Hide resolved
...ages/react-storage/src/components/StorageBrowser/views/LocationActionView/Controls/Title.tsx Show resolved Hide resolved
cshfang
cshfang reviewed Nov 6, 2024
View reviewed changes
packages/react-storage/src/components/StorageBrowser/composables/Title.tsx Outdated Show resolved Hide resolved
packages/react-storage/src/components/StorageBrowser/composables/__tests__/Title.spec.tsx Outdated Show resolved Hide resolved
packages/react-storage/src/components/StorageBrowser/controls/hooks/__tests__/useTitle.spec.tsx Outdated Show resolved Hide resolved
packages/react-storage/src/components/StorageBrowser/controls/hooks/__tests__/useTitle.spec.tsx Outdated Show resolved Hide resolved
...ages/react-storage/src/components/StorageBrowser/views/LocationActionView/UploadControls.tsx Outdated Show resolved Hide resolved
...react-storage/src/components/StorageBrowser/views/LocationActionView/DeleteFilesControls.tsx Outdated Show resolved Hide resolved
...eact-storage/src/components/StorageBrowser/views/LocationActionView/CreateFolderControls.tsx Outdated Show resolved Hide resolved
...s/react-storage/src/components/StorageBrowser/views/LocationActionView/CopyFilesControls.tsx Outdated Show resolved Hide resolved
@joon-won joon-won force-pushed the feat-storage-browser/refactor-title-finale branch from 90143ea to 5456e8f Compare November 7, 2024 08:13
@joon-won
Copy link
Member Author

joon-won commented Nov 9, 2024

composable moved to #6040

@joon-won joon-won closed this Nov 9, 2024
@joon-won joon-won deleted the feat-storage-browser/refactor-title-finale branch November 13, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dindjarinjs dindjarinjs dindjarinjs requested changes

@Samaritan1011001 Samaritan1011001 Awaiting requested review from Samaritan1011001

@ashwinkumar6 ashwinkumar6 Awaiting requested review from ashwinkumar6

@calebpollman calebpollman Awaiting requested review from calebpollman

@cshfang cshfang Awaiting requested review from cshfang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joon-won @cshfang @Samaritan1011001 @calebpollman @ashwinkumar6 @dindjarinjs