feat(react-storage): refactor useView action related hooks #5998

Samaritan1011001 · 2024-11-01T23:23:56Z

Description of changes

add useUploadView
align useView action interfaces
move view button disabling logic to components
add statusCounts, isProcessing and isProcessingComplete values to useProcessTasks return

Issue #, if available

Description of how you validated changes

Unit tests

Checklist

Have read the Pull Request Guidelines
PR description included
yarn test passes and tests are updated/added
PR title and commit messages follow conventional commit syntax
If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

...react-storage/src/components/StorageBrowser/views/LocationActionView/DeleteFilesControls.tsx

changeset-bot · 2024-11-01T23:58:02Z

⚠️ No Changeset found

Latest commit: 731f099

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

...mponents/StorageBrowser/views/LocationActionView/DeleteView/__tests__/useDeleteView.spec.tsx

…bleData, update Table cell types to include key in base definition

...c/components/StorageBrowser/views/LocationActionView/CopyView/__tests__/useCopyView.spec.tsx

calebpollman · 2024-11-07T18:28:08Z

packages/react-storage/src/components/StorageBrowser/actions/handlers/copy.ts

-  const destinationPath = `${path}${getFilenameWithoutPrefix(sourcePath)}`;
+  const destinationPath = `${path}${fileKey}`;


Updated the approach here to allow to improve consumer ergonomics by providing just the parsed fileKey as well as the full key

calebpollman · 2024-11-07T18:28:24Z

packages/react-storage/src/components/StorageBrowser/actions/handlers/copy.ts

@@ -1,17 +1,15 @@
 import { copy } from '../../storage-internal';
-import { getFilenameWithoutPrefix } from '../../views/LocationActionView/utils';


Removed to fix a circular dependency

calebpollman · 2024-11-07T18:28:53Z

packages/react-storage/src/components/StorageBrowser/actions/handlers/listLocationItems.ts

-export interface FolderData {
-  key: string;
-  id: string;
-  type: 'FOLDER';
-}
-
-export interface FileData {
-  key: string;
-  lastModified: Date;
-  id: string;
-  size: number;
-  type: 'FILE';
-}


Moved to sibling types.ts

calebpollman · 2024-11-07T18:30:01Z

packages/react-storage/src/components/StorageBrowser/actions/handlers/types.ts

Interfaces in this file were migrated from ../types.ts to avoid potential circular references

calebpollman · 2024-11-07T18:31:12Z

packages/react-storage/src/components/StorageBrowser/tasks/types.ts

@@ -8,6 +8,8 @@ export type TaskStatus =
  | 'QUEUED'
  | 'PENDING';

+export type StatusCounts = Record<TaskStatus | 'TOTAL', number>;


Replaces TasksCount

...omponents/StorageBrowser/views/LocationActionView/UploadView/__tests__/useUploadView.spec.ts

calebpollman · 2024-11-07T19:21:40Z

.../components/StorageBrowser/views/LocationDetailView/__tests__/useLocationDetailView.spec.tsx

-      type: 'RESET_LOCATION_ITEMS',
+      type: 'SET_LOCATION_ITEMS',
+      items: [fileDataOne, fileDataTwo],


Was asserting the opposite behavior of the test description, same issue with the test case immediately below

dindjarinjs

Still reviewing but publishing a few comments

...s/react-storage/src/components/StorageBrowser/views/LocationActionView/CopyFilesControls.tsx

cshfang · 2024-11-07T19:50:56Z

packages/react-storage/src/components/StorageBrowser/actions/handlers/types.ts

+
+export interface TaskHandlerInput<
+  T extends TaskData = TaskData,
+  K extends TaskHandlerOptions = TaskHandlerOptions,


Nit: Isn't K usually short for "Key"?

Generally we have treated usage of K as a second positional generic name

We should maybe rethink this later. K is definitely a convention but we seem to be misusing it a bit

...react-storage/src/components/StorageBrowser/views/LocationActionView/CopyView/useCopyView.ts

...ages/react-storage/src/components/StorageBrowser/views/LocationActionView/UploadControls.tsx

...omponents/StorageBrowser/views/LocationActionView/UploadView/__tests__/useUploadView.spec.ts

feat: useUploadView

14d6400

Samaritan1011001 requested a review from a team as a code owner November 1, 2024 23:23

Samaritan1011001 mentioned this pull request Nov 1, 2024

chore(react-storage): add useUploadView hook #5978

Closed

5 tasks

reesscot reviewed Nov 1, 2024

View reviewed changes

...react-storage/src/components/StorageBrowser/views/LocationActionView/DeleteFilesControls.tsx Outdated Show resolved Hide resolved

chore: update tests for disable buttons

78db8a5

Samaritan1011001 commented Nov 1, 2024

View reviewed changes

...mponents/StorageBrowser/views/LocationActionView/DeleteView/__tests__/useDeleteView.spec.tsx Outdated Show resolved Hide resolved

Samaritan1011001 and others added 4 commits November 1, 2024 17:17

chore: update bundle size

c72df9f

Merge branch 'feat-storage-browser/main' into feat/useUploadView

69ba65c

Merge branch 'feat-storage-browser/main' into feat/useUploadView

23bf486

refactor useView action hooks

00565b4

calebpollman changed the title ~~feat(react-storage): useUploadView~~ feat(react-storage): refactor useView action related hooks Nov 6, 2024

calebpollman added 3 commits November 6, 2024 16:50

add useUploadView unit tests

13296f8

Merge branch 'feat-storage-browser/main' into feat/useUploadView

22759c5

remove ActionType to allow for upload view support in getActionViewTa…

49dfe0c

…bleData, update Table cell types to include key in base definition

calebpollman force-pushed the feat/useUploadView branch from c94cec9 to 49dfe0c Compare November 7, 2024 01:28

calebpollman had a problem deploying to ci November 7, 2024 01:38 — with GitHub Actions Error

remove table interface changes

4bb6ca7

calebpollman temporarily deployed to ci November 7, 2024 01:53 — with GitHub Actions Inactive

jordanvn reviewed Nov 7, 2024

View reviewed changes

...c/components/StorageBrowser/views/LocationActionView/CopyView/__tests__/useCopyView.spec.tsx Outdated Show resolved Hide resolved

calebpollman mentioned this pull request Nov 7, 2024

fix: missing search in detail view #6023

Merged

5 tasks

calebpollman added 2 commits November 7, 2024 10:13

address circular dep in copy.ts, modify locationItems state

e0a03ce

Merge branch 'feat-storage-browser/main' into feat/useUploadView

4165171

calebpollman reviewed Nov 7, 2024

View reviewed changes

calebpollman temporarily deployed to ci November 7, 2024 18:36 — with GitHub Actions Inactive

jordanvn reviewed Nov 7, 2024

View reviewed changes

...omponents/StorageBrowser/views/LocationActionView/UploadView/__tests__/useUploadView.spec.ts Outdated Show resolved Hide resolved

dbanksdesign previously approved these changes Nov 7, 2024

View reviewed changes

calebpollman reviewed Nov 7, 2024

View reviewed changes

dindjarinjs reviewed Nov 7, 2024

View reviewed changes

...s/react-storage/src/components/StorageBrowser/views/LocationActionView/CopyFilesControls.tsx Outdated Show resolved Hide resolved

address feedback

aad8844

calebpollman dismissed dbanksdesign’s stale review via aad8844 November 7, 2024 20:02

cshfang reviewed Nov 7, 2024

View reviewed changes

fix missed update from previous commit

731f099

calebpollman temporarily deployed to ci November 7, 2024 20:53 — with GitHub Actions Inactive

dindjarinjs approved these changes Nov 7, 2024

View reviewed changes

cshfang approved these changes Nov 7, 2024

View reviewed changes

calebpollman merged commit 9dfd322 into feat-storage-browser/main Nov 7, 2024
34 checks passed

calebpollman deleted the feat/useUploadView branch November 7, 2024 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(react-storage): refactor useView action related hooks #5998

feat(react-storage): refactor useView action related hooks #5998

Samaritan1011001 commented Nov 1, 2024 •

edited by calebpollman

Loading

changeset-bot bot commented Nov 1, 2024 •

edited

Loading

calebpollman Nov 7, 2024

calebpollman Nov 7, 2024

calebpollman Nov 7, 2024

calebpollman Nov 7, 2024

calebpollman Nov 7, 2024

calebpollman Nov 7, 2024

dindjarinjs left a comment

cshfang Nov 7, 2024

calebpollman Nov 7, 2024

cshfang Nov 7, 2024

		const destinationPath = `${path}${getFilenameWithoutPrefix(sourcePath)}`;
		const destinationPath = `${path}${fileKey}`;

		@@ -1,17 +1,15 @@
		import { copy } from '../../storage-internal';
		import { getFilenameWithoutPrefix } from '../../views/LocationActionView/utils';

feat(react-storage): refactor useView action related hooks #5998

feat(react-storage): refactor useView action related hooks #5998

Conversation

Samaritan1011001 commented Nov 1, 2024 • edited by calebpollman Loading

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

changeset-bot bot commented Nov 1, 2024 • edited Loading

⚠️ No Changeset found

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dindjarinjs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Samaritan1011001 commented Nov 1, 2024 •

edited by calebpollman

Loading

changeset-bot bot commented Nov 1, 2024 •

edited

Loading