Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merges main into feature branch #5381

Merged
merged 12 commits into from
Jul 11, 2024
Merged

Conversation

AhmetAhunbayAWS
Copy link
Contributor

Description of changes

merges main into feature branch

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

esauerbo and others added 7 commits July 2, 2024 16:18
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…b order (#5376)

* fix(SearchField): accessibility - do not exclude clear button from tab order

* Create eighty-candles-complain.md

---------

Co-authored-by: Tim Nguyen <[email protected]>
…5321)

* Adjusts RatingIcon component

* Adjusts display for amplify-rating class

* adds test case for additional class

* extends the RatingIconProps to include the BaseComponentProps

* Adds changeset

* Adds more context into changeset summary

* fixed ordering of imports to match standards

* remove unneccessary asyc

* removed BaseComponentProps inheritance

* cleaned up test
@AhmetAhunbayAWS AhmetAhunbayAWS requested a review from a team as a code owner July 10, 2024 20:12
Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: f9d1ddd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants