fix(rna): prefer route over authStatus for rendering children #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0c0d821 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
reesscot
reviewed
Nov 14, 2023
| switch (APP) { | ||
| const appName = getExampleAppName(); | ||
|
|
||
| console.log(`Running Example App: ${appName}`); |
There was a problem hiding this comment.
curious, is the console.log still required, or is this just a nice thing for us to know we're running the right app?
There was a problem hiding this comment.
Just added it for debugging 😄
thaddmt
approved these changes
Nov 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update
Authenticatorto delay renderingchildrenuntil attribute verification flow has been completedIssue #, if available
NA
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.