Merge next-release/main to main #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Caleb Pollman <[email protected]>
Co-authored-by: Scott Rees <[email protected]>
This reverts commit 25eae4c.
This reverts commit 2c7a887.
Co-authored-by: Danny Banks <[email protected]>
* refactor(ui): update radiogroupfield to use fieldset instead of view as fieldset, update references and docs * refactor(ui): updating test cases * update tests * Create plenty-apples-end.md * refactor(ui): change radiofieldgroup to use fieldset * Update .changeset/plenty-apples-end.md Co-authored-by: Heather Buchel <[email protected]> * Update package.json * Update packages/react/src/primitives/types/radioGroupField.ts Co-authored-by: Heather Buchel <[email protected]> * Update packages/react/src/primitives/RadioGroupField/__tests__/RadioGroupField.test.tsx Co-authored-by: Heather Buchel <[email protected]> * update tests * Update docs/src/pages/[platform]/components/radiogroupfield/react.mdx Co-authored-by: Heather Buchel <[email protected]> * Update docs/src/pages/[platform]/components/radiogroupfield/react.mdx Co-authored-by: Heather Buchel <[email protected]> * Update docs/src/pages/[platform]/components/radiogroupfield/react.mdx Co-authored-by: Heather Buchel <[email protected]> * Update docs/src/pages/[platform]/components/radiogroupfield/react.mdx Co-authored-by: Heather Buchel <[email protected]> * Update docs/src/pages/[platform]/components/radiogroupfield/react.mdx Co-authored-by: Heather Buchel <[email protected]> * updating syntax * disabling outlined by default in fieldset * docs fix * fix radio disabled label color and radioGroup legend theming (#4478) * fix radio disabled label color and radioGroup legend theming * snapshots --------- Co-authored-by: Heather Buchel <[email protected]> * Fix Radio tests after disabled class change * updating yarn lock * reset yarn.lock to next-release/main * capitalization and alphabetization * Update .changeset/plenty-apples-end.md Co-authored-by: Caleb Pollman <[email protected]> --------- Co-authored-by: Heather Buchel <[email protected]> Co-authored-by: Heather Buchel <[email protected]> Co-authored-by: Caleb Pollman <[email protected]>
--------- Co-authored-by: Scott Rees <[email protected]>
Co-authored-by: Scott Rees <[email protected]>
…sword References (#4695) * fix(ci): enable last commented out e2e tests, remove last of resetPassword refs * Update packages/e2e/features/ui/components/authenticator/sign-in-with-email.feature --------- Co-authored-by: Scott Rees <[email protected]>
* fix missing package.json update for angular cli 16 build system test (#4687) * chore: update aws-amplify to latest (#4696) --------- Co-authored-by: Heather Buchel <[email protected]>
Co-authored-by: Scott Rees <[email protected]>
* chore(mv): replace AmplifyUser with AuthUser * chore: update attributes useage to username in xample apps --------- Co-authored-by: Scott Rees <[email protected]>
* chore: add fixture for change password e2e test * run e2e tests
🦋 Changeset detectedLatest commit: 75c748f The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
calebpollman
commented
Nov 14, 2023
wlee221
reviewed
Nov 14, 2023
| const cliPasswordSettings = | ||
| event.data.aws_cognito_password_protection_settings || {}; | ||
| config(context, { data: cliConfig }) { | ||
| // Prefer explicitly configured settings over default CLI values\ |
There was a problem hiding this comment.
Suggested change
| // Prefer explicitly configured settings over default CLI values\ | |
| // Prefer explicitly configured settings over default CLI values |
reesscot
approved these changes
Nov 14, 2023
Milan-Shah
approved these changes
Nov 14, 2023
esauerbo
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.