Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix RN e2e tests #4632

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Conversation

reesscot
Copy link
Contributor

@reesscot reesscot commented Nov 5, 2023

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reesscot reesscot requested a review from a team as a code owner November 5, 2023 00:04
Copy link

changeset-bot bot commented Nov 5, 2023

⚠️ No Changeset found

Latest commit: b014215

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@reesscot reesscot changed the base branch from main to next-release/main November 5, 2023 00:05
Comment on lines +11 to +16
const config = parseAWSExports(awsconfig);
if (!config.Auth) {
throw new Error('Auth config not found');
}
// mock server endpoint for Detox e2es
config.Auth.Cognito.userPoolEndpoint = 'http://127.0.0.1:9091/';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking we make a util for this and add an .env variable for USER_POOL_END_POINT so we can use these examples for manual testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to pick your brain on this since I can't get other env like EXAMPLE APP variables to work when testing locally.

@calebpollman calebpollman merged commit 4206683 into next-release/main Nov 6, 2023
28 checks passed
@calebpollman calebpollman deleted the reesscot-fix-rn-tests branch November 6, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants