Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate password validators #4529

Merged
merged 10 commits into from
Oct 13, 2023
Merged

chore: Migrate password validators #4529

merged 10 commits into from
Oct 13, 2023

Conversation

ioanabrooks
Copy link
Contributor

@ioanabrooks ioanabrooks commented Oct 10, 2023 •
edited
Loading

Description of changes

  • Update password validators to conform to Amplify configure changes.
  • Re-enable Change Password e2es
  • Re-enable Delete User e2es.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ioanabrooks ioanabrooks requested a review from a team as a code owner October 10, 2023 23:27
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ad187cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ioanabrooks ioanabrooks force-pushed the next-release/migrate-pwd-reqs branch from a1cc8e3 to 6a897bd Compare October 10, 2023 23:30
@ioanabrooks ioanabrooks temporarily deployed to ci October 10, 2023 23:47 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 10, 2023 23:47 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 11, 2023 04:51 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 11, 2023 04:51 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks marked this pull request as draft October 11, 2023 16:15
@ioanabrooks ioanabrooks temporarily deployed to ci October 11, 2023 20:14 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 11, 2023 20:14 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 11, 2023 20:14 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 11, 2023 20:14 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks marked this pull request as ready for review October 11, 2023 20:36
@ioanabrooks ioanabrooks marked this pull request as draft October 12, 2023 17:02
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 15:47 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 15:47 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 15:47 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks marked this pull request as ready for review October 13, 2023 19:51
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 19:59 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 19:59 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 19:59 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 19:59 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 21:10 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 21:10 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 21:10 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 21:51 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 21:51 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 21:51 — with GitHub Actions Inactive
@ioanabrooks ioanabrooks temporarily deployed to ci October 13, 2023 21:51 — with GitHub Actions Inactive
esauerbo
esauerbo approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@esauerbo esauerbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

thaddmt
thaddmt approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@thaddmt thaddmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ioanabrooks ioanabrooks merged commit aaa6c20 into next-release/migration Oct 13, 2023
16 checks passed
@ioanabrooks ioanabrooks deleted the next-release/migrate-pwd-reqs branch October 13, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esauerbo esauerbo esauerbo approved these changes

@thaddmt thaddmt thaddmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ioanabrooks @thaddmt @esauerbo