fix(liveness): use button/aria roles for photosensitivity warning #4506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e99da7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
esauerbo
changed the title
reesscot
reviewed
Oct 3, 2023
…ub.com/aws-amplify/amplify-ui into liveness/photosensitivit-accessibility
hbuchel
reviewed
Oct 3, 2023
packages/react-liveness/src/components/FaceLivenessDetector/shared/LivenessIconWithPopover.tsx
Outdated
Show resolved
Hide resolved
packages/react-liveness/src/components/FaceLivenessDetector/shared/LivenessIconWithPopover.tsx
Show resolved
Hide resolved
packages/react-liveness/src/components/FaceLivenessDetector/shared/LivenessIconWithPopover.tsx
Outdated
Show resolved
Hide resolved
packages/react-liveness/src/components/FaceLivenessDetector/shared/LivenessIconWithPopover.tsx
Outdated
Show resolved
Hide resolved
… liveness/photosensitivit-accessibility
…ub.com/aws-amplify/amplify-ui into liveness/photosensitivit-accessibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
dialogrole to the popover contentaria-hiddenset totrueorfalsedepending on whether it's open or closedaria-labelaria-labelnoting its purposearia-haspopupset todialogaria-expandedset totrueorfalsedepending on whether content is open or closedaria-controlsset to the content id (popover-text)Issue #, if available
Description of how you validated changes
Visual inspection of accessibility settings on chrome
Used keyboard to navigate to and open/close popup
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.