-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): Add esbuild dev dependency #4468
Conversation
|
esbuild@^0.19.3: | ||
version "0.19.3" | ||
resolved "https://registry.yarnpkg.com/esbuild/-/esbuild-0.19.3.tgz#d9268cd23358eef9d76146f184e0c55ff8da7bb6" | ||
integrity sha512-UlJ1qUUA2jL2nNib1JTSkifQTcYTroFqRjwCFW4QYEKEsixXD5Tik9xML7zh2gTxkYTBKGHNH9y7txMwVyPbjw== | ||
optionalDependencies: | ||
"@esbuild/android-arm" "0.19.3" | ||
"@esbuild/android-arm64" "0.19.3" | ||
"@esbuild/android-x64" "0.19.3" | ||
"@esbuild/darwin-arm64" "0.19.3" | ||
"@esbuild/darwin-x64" "0.19.3" | ||
"@esbuild/freebsd-arm64" "0.19.3" | ||
"@esbuild/freebsd-x64" "0.19.3" | ||
"@esbuild/linux-arm" "0.19.3" | ||
"@esbuild/linux-arm64" "0.19.3" | ||
"@esbuild/linux-ia32" "0.19.3" | ||
"@esbuild/linux-loong64" "0.19.3" | ||
"@esbuild/linux-mips64el" "0.19.3" | ||
"@esbuild/linux-ppc64" "0.19.3" | ||
"@esbuild/linux-riscv64" "0.19.3" | ||
"@esbuild/linux-s390x" "0.19.3" | ||
"@esbuild/linux-x64" "0.19.3" | ||
"@esbuild/netbsd-x64" "0.19.3" | ||
"@esbuild/openbsd-x64" "0.19.3" | ||
"@esbuild/sunos-x64" "0.19.3" | ||
"@esbuild/win32-arm64" "0.19.3" | ||
"@esbuild/win32-ia32" "0.19.3" | ||
"@esbuild/win32-x64" "0.19.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the diff here has me wondering if we could just bump @badeball/cypress-cucumber-preprocessor
to get the required @esbuild
deps. For context:
➜ amplify-ui git:(ui-react-auth/add-rn-clipboard) ✗ npm ls @esbuild/darwin-arm64
amplify-ui@ /Users/cpollman/Amplify/x_backup/amplify-ui
├─┬ @aws-amplify/[email protected] -> ./packages/angular
│ └─┬ [email protected]
│ └─┬ [email protected]
│ └── @esbuild/[email protected]
└─┬ @aws-amplify/[email protected] -> ./packages/e2e
└─┬ @badeball/[email protected]
└─┬ [email protected]
└── @esbuild/[email protected] deduped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
badeball/cypress-cucumber-preprocessor
>=v17 requires node18 or higher (release note) so that is going to be a no go for now.
Description of changes
Add esbuild dependency for
bahmutov/cypress-esbuild-preprocessor
as required in their install instructions (ref) to run e2e tests locally.Issue #, if available
Description of how you validated changes
Ran e2e locally.
Checklist
yarn test
passes and tests are updated/addedsideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.