Skip to content

Commit

Permalink
chore: temporarily set react@latest to 18 in build tests (#6237)
Browse files Browse the repository at this point in the history
  • Loading branch information
calebpollman authored Dec 6, 2024
1 parent 303c250 commit 9069cac
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/reusable-build-system-test-react-native.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ jobs:
fail-fast: false
matrix:
framework: [react-native]
framework-version:
[
framework-version: [
# uncomment to enable
# { formatted: latest, value: latest },
{ formatted: 075, value: 0.75 },
Expand Down Expand Up @@ -53,8 +52,8 @@ jobs:
platform: android
framework-version: { formatted: '071', value: '0.71' }
include:
# Expo makes you specify a version of the SDK that supports that a particular version of React Native
# https://stackoverflow.com/questions/63463373/create-an-expo-project-with-a-specific-version
# Expo makes you specify a version of the SDK that supports a specific version of React Native
# https://stackoverflow.com/questions/63463373/create-an-expo-project-with-a-specific-version
- framework: react-native
framework-version: { formatted: 070, value: '0.70' }
build-tool: expo
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/reusable-build-system-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ jobs:
fail-fast: false
matrix:
framework: [react]
framework-version: [latest]
# temporarily pointing all react tests to v18
# framework-version: [latest]
framework-version: [18]
build-tool: [next, vite]
build-tool-version: [latest]
pkg-manager: [npm]
Expand Down

0 comments on commit 9069cac

Please sign in to comment.