-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(predictions): add web socket retry for clock skew #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Breakage Report✅ No Public API Breaking Change detected |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3816 +/- ##
==========================================
+ Coverage 68.54% 68.63% +0.09%
==========================================
Files 1080 1080
Lines 37608 37647 +39
==========================================
+ Hits 25778 25840 +62
+ Misses 11830 11807 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
phantumcode
reviewed
Aug 16, 2024
AmplifyPlugins/Predictions/AWSPredictionsPlugin/Dependency/AWSTranscribeStreamingAdapter.swift
Show resolved
Hide resolved
phantumcode
reviewed
Aug 16, 2024
AmplifyPlugins/Predictions/AWSPredictionsPlugin/Liveness/Service/WebSocketSession.swift
Show resolved
Hide resolved
API Breakage Report✅ No Public API Breaking Change detected |
phantumcode
approved these changes
Aug 16, 2024
tylerjroach
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Some liveness customers are setting up date on the device manually. This causes a clock skew when AWS Rekognition server time is different than device time and the signature calculated is incorrect. AWS Rekognition supports a maximum skew of 5 minutes. This leads to customer receiving
IncorrectSignatureException
.Description
This change adds a one-time retry for web socket connection when an
InvalidSignatureException
is received.This is in line with Android implementation here : aws-amplify/amplify-android#2634
Testing
Happy path - I performed manual testing by setting the device date manually for +1hr and -1hr of actual time. I tested for both cases when preview screen is enabled or not enabled in the
FaceLivenessDetectorView
component.Error path - I uncommented the line
to mimic the case when we don't receive
Date
header indelegate callback. I tested for both cases when preview screen is enabled or not enabled in the
FaceLivenessDetectorView
component.General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.