chore: add swift version support blurb in readme #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdworld11
previously approved these changes
May 17, 2024
atierian
changed the title
|
Removed the tools-version bump in this PR as it's already handled in #3655 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3709 +/- ##
==========================================
+ Coverage 68.48% 68.50% +0.02%
==========================================
Files 1096 1096
Lines 38088 38088
==========================================
+ Hits 26084 26092 +8
+ Misses 12004 11996 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
harsh62
approved these changes
May 17, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description
General Checklist
Added new tests to cover change, if neededBuild succeeds with all target using Swift Package ManagerAll unit tests passAll integration tests passSecurity oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)Documentation update for the change if requiredNew or updated tests includeGiven When Theninline code documentation and are named accordinglytestThing_condition_expectation()If breaking change, documentation/changelog update with migration instructionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.