Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): refactor datastore category to use APICategoryGraphQLBehavior #3666

Merged
merged 36 commits into from
Jun 3, 2024

Conversation

5d
Copy link
Member

@5d 5d commented May 1, 2024

Issue #

Description

  • refactor datastore category to use APICategoryGraphQLBehavior
  • remove the indirect dependency of the aws-sdk-swift library on the datastore category

Including PRs:

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d had a problem deploying to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest May 1, 2024 18:04 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d had a problem deploying to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Failure
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 3, 2024 20:52 — with GitHub Actions Inactive
@ukhan-amazon ukhan-amazon self-requested a review June 3, 2024 21:27
@5d 5d merged commit 108afe9 into main Jun 3, 2024
135 of 136 checks passed
@5d 5d deleted the flutter-datastore-v2 branch June 3, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants