fix(Auth): Fix multiple continuation resumes in hostedUI #3466
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh62
force-pushed
the
fix/continuation-crash-hosted-ui
branch
from
b81c3b8 to
3b4da32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3466 +/- ##
==========================================
+ Coverage 68.06% 68.12% +0.06%
==========================================
Files 1079 1016 -63
Lines 36356 34454 -1902
==========================================
- Hits 24746 23473 -1273
+ Misses 11610 10981 -629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lawmicha
previously approved these changes
Jan 11, 2024
| (continuation: CheckedContinuation<[URLQueryItem], Error>) in | ||
| guard let self = self else { return } |
There was a problem hiding this comment.
here and below
Suggested change
| guard let self = self else { return } | |
| guard let self else { return } |
lawmicha
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#3362
Description
The PR is aimed at using weak references in the completion blocks of continuations to avoid any retain cycles and at the same time also use the
canStartAPI available in ASWebAuthentication to only start if its possible.General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.