Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): update pending mutation events version from mutation response #3452

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

5d
Copy link
Member

@5d 5d commented Jan 3, 2024

Issue #

Description

  • rollback the logic for updating the version of pending mutation events in the queue upon receiving a mutation response from the remote server with the same model id.
  • detect the mutation event version based on both latest synced metadata and existing mutation event's version.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 3, 2024 21:30 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 18:53 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 18:53 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 18:53 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 18:53 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 4, 2024 20:42 — with GitHub Actions Inactive
@5d 5d requested a review from lawmicha January 4, 2024 21:35
@5d 5d merged commit 2abaf4c into main Jan 5, 2024
139 checks passed
@5d 5d deleted the 5d/fix-reconcile-version branch January 5, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants