Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding xcprivacy to all targets for privacy API access #3343

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Nov 3, 2023

Issue

#3327

Description

Describing use of required reason API

As required by the Apple App Store, we provide the new PrivacyInfo.xcprivacy file for describing use of required reason API, see Describing use of required reason API. You can also export the privacy report after archiving your App in Xcode, see Exporting a privacy report.

Following Amplify targets have been identified to be using the User Default APIs.

  • AWSCognitoAuthPlugin
  • AWSDataStorePlugin
  • AWSCloudWatchLoggingPlugin
  • InternalAWSPinpoint

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 changed the title Feat/declaration privacy api chore: Adding xcprivacy to all targets for privacy API access Nov 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #3343 (e3f8399) into main (2604241) will increase coverage by 8.78%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3343      +/-   ##
==========================================
+ Coverage   59.44%   68.22%   +8.78%     
==========================================
  Files           7     1075    +1068     
  Lines         466    35868   +35402     
==========================================
+ Hits          277    24471   +24194     
- Misses        189    11397   +11208     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (?)
AWSPluginsCore 66.15% <ø> (?)
Amplify 47.83% <ø> (?)
Analytics_plugin_unit_test 81.16% <ø> (?)
Auth_plugin_unit_test 79.29% <ø> (?)
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.08% <ø> (?)
Geo_plugin_unit_test 70.75% <ø> (?)
Logging_plugin_unit_test 63.09% <ø> (?)
Predictions_plugin_unit_test 37.29% <ø> (?)
PushNotifications_plugin_unit_test 87.03% <ø> (?)
Storage_plugin_unit_test 78.10% <ø> (?)
unit_tests 68.22% <ø> (+8.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1068 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@harsh62 harsh62 marked this pull request as ready for review November 3, 2023 15:48
@harsh62 harsh62 requested a review from a team as a code owner November 3, 2023 15:48
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Villena <[email protected]>
Co-authored-by: Sebastian Villena <[email protected]>
@harsh62 harsh62 merged commit 46b6563 into main Nov 7, 2023
76 checks passed
@harsh62 harsh62 deleted the feat/declaration-privacy-api branch November 7, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants