fix(Analytics): Fixing crash when attempting to submit events while a previous submission is in progress #3331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
This PR fixes a crash that was happening when
EventRecorder.submitAllEvents()
was called while a previous submission was still ongoing.This happened because the
submittedEvents
array was being populated by the previous submission, while the very first thing a new one does is to set it to[]
.I am changing the behaviour so that
submitAllEvents
now waits until the previous submission ends before continuing. I've explored just using a lock to manipulate the array instead, but while that did fix the crash, it would still produce undetermined behaviour when the array was emptied.General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.