Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update swift-sdk dependency to 0.29.0 #3330

Closed
wants to merge 8 commits into from

Conversation

atierian
Copy link
Member

@atierian atierian commented Oct 26, 2023

Description

Updates dependency on AWS SDK for Swift from 0.26.0 to 0.30.0.
This is needed to pull in changes released in 0.29.0 that removed a compiler error when building for visionOS.
Additionally, 0.30.0 updates aws-crt-swift to a version without a SPI header for crypto operations that was leading to app store rejections.

Once this update lands in main, it will need to be pulled into the visionos-preview branch.

  • Renames SDK response types from *OutputResponse to *Output.
  • Restructures to Auth test harness to work around SDK *OutputError types becoming internal.
  • Adds some missing methods to *ClientProtocol conformances in Predictions unit test suite.
  • Pulls UploadPartOutputError from SDK into Amplify to allow UploadPart presigning method to continue working after SDK removed public access.

TODO

  • Ensure that Storage presignedURL change works as expected.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian temporarily deployed to Fortify October 26, 2023 19:01 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:09 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:15 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:16 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:16 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:16 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:16 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:16 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:16 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:16 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:16 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #3330 (2bbb55b) into main (d4b957d) will decrease coverage by 0.04%.
The diff coverage is 25.92%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
- Coverage   68.22%   68.19%   -0.04%     
==========================================
  Files        1075     1075              
  Lines       35876    35878       +2     
==========================================
- Hits        24478    24466      -12     
- Misses      11398    11412      +14     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 66.19% <ø> (ø)
Amplify 47.83% <ø> (ø)
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.28% <ø> (-0.02%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.08% <ø> (ø)
Geo_plugin_unit_test 70.75% <0.00%> (ø)
Logging_plugin_unit_test 63.09% <100.00%> (ø)
Predictions_plugin_unit_test 37.29% <66.66%> (ø)
PushNotifications_plugin_unit_test 87.03% <ø> (ø)
Storage_plugin_unit_test 77.73% <0.00%> (-0.38%) ⬇️
unit_tests 68.19% <25.92%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gin/Actions/SignIn/SRPAuth/VerifyPasswordSRP.swift 94.62% <ø> (ø)
.../Service/Helpers/SignUpOutputResponse+Helper.swift 96.15% <ø> (ø)
...ugin/StateMachine/CodeGen/Events/SignInEvent.swift 52.17% <ø> (ø)
...ingPlugin/Consumer/CloudWatchLoggingConsumer.swift 93.75% <100.00%> (ø)
.../Predictions/AWSPredictionsService+Translate.swift 96.42% <100.00%> (ø)
...upport/Internal/StorageMultipartUploadClient.swift 98.43% <ø> (ø)
...e/Predictions/AWSPredictionsService+Textract.swift 74.07% <50.00%> (ø)
.../AWSS3StoragePlugin/Dependency/AWSS3Behavior.swift 0.00% <0.00%> (ø)
...lugin/Dependency/AWSS3ListUploadPartResponse.swift 0.00% <0.00%> (-66.67%) ⬇️
...n/Dependency/AWSS3PreSignedURLBuilderAdapter.swift 67.56% <0.00%> (+3.46%) ⬆️
... and 3 more

... and 5 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:38 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:38 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:38 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 19:38 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 20:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 20:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 26, 2023 20:03 — with GitHub Actions Inactive
@atierian
Copy link
Member Author

atierian commented Nov 6, 2023

Closing in favor of:

@atierian atierian closed this Nov 6, 2023
@atierian atierian deleted the swift-sdk-0290 branch March 28, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants