Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixing retries in unit tests workflow #3293

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Oct 12, 2023

Description

Only setting test-without-building to true if there was a cache for the exact SHA that's being tested, or if there wasn't a main build cached.

Otherwise the retry would end up using an old successful build and result in a success, even if the actual tests in the current commit are not passing.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas requested a review from a team as a code owner October 12, 2023 19:37
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #3293 (62548c7) into main (efc0061) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3293      +/-   ##
==========================================
- Coverage   64.32%   64.31%   -0.02%     
==========================================
  Files        1075     1075              
  Lines       35880    35880              
==========================================
- Hits        23079    23075       -4     
- Misses      12801    12805       +4     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 66.15% <ø> (ø)
Amplify 47.92% <ø> (+0.06%) ⬆️
Analytics_plugin_unit_test 81.37% <ø> (ø)
Auth_plugin_unit_test 74.00% <ø> (-0.09%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.07% <ø> (+0.01%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 60.29% <ø> (ø)
Storage_plugin_unit_test 54.24% <ø> (ø)
unit_tests 64.31% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruisebas ruisebas merged commit ec5a64d into main Oct 12, 2023
76 checks passed
@ruisebas ruisebas deleted the ruisebas/disable_test_without_build branch October 12, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants