Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remaining integration tests for sdk update #3283

Merged
merged 14 commits into from
Oct 9, 2023

Conversation

atierian
Copy link
Member

@atierian atierian commented Oct 5, 2023

Swift SDK Update 0.26.0

  • Predictions and Auth integration tests use macos-13 runner w/ Xcode 14.3.1
  • Updates Package.resolved for new dependency versions in a few HostApp targets.
  • Relaxes assertions in Auth integration test cases expecting userNotFound to allow for limitedExceeded exceptions.
  • Switches over to fulfillment(of:) in a couple tests within async contexts.
  • Disables parallel execution of AuthHostedUIApp integration test cases (doesn't play nice with action runners).
  • Adds userAgentOS to AmplifyAWSServiceConfiguration for Storage requests that aren't generated or executed through the Swift SDK.
  • Fixes incorrect assertion in CoreMLPredictionsPluginIntegrationTests.
  • Removes non-executed code paths from PredictionsHostApp.

Debt Introduced

none

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian requested a review from a team as a code owner October 5, 2023 20:59
@atierian atierian temporarily deployed to IntegrationTest October 5, 2023 21:00 — with GitHub Actions Inactive
@atierian atierian marked this pull request as draft October 5, 2023 21:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #3283 (3fc0039) into swift-sdk-0260 (6322946) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                Coverage Diff                 @@
##           swift-sdk-0260    #3283      +/-   ##
==================================================
+ Coverage           64.45%   64.47%   +0.01%     
==================================================
  Files                1074     1074              
  Lines               35875    35875              
==================================================
+ Hits                23122    23129       +7     
+ Misses              12753    12746       -7     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 66.08% <ø> (ø)
Amplify 47.84% <ø> (ø)
Analytics_plugin_unit_test 81.37% <ø> (ø)
Auth_plugin_unit_test 73.98% <ø> (+0.06%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.08% <ø> (ø)
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 60.29% <ø> (ø)
Storage_plugin_unit_test 54.24% <100.00%> (ø)
unit_tests 64.47% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gePlugin/Service/Storage/AWSS3StorageService.swift 39.18% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atierian atierian temporarily deployed to Fortify October 9, 2023 14:56 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 14:57 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 14:57 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to Fortify October 9, 2023 15:35 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:03 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to Fortify October 9, 2023 17:31 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:35 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 17:35 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to Fortify October 9, 2023 18:18 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 18:19 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 18:19 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 9, 2023 18:19 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to Fortify October 9, 2023 18:33 — with GitHub Actions Inactive
@atierian atierian marked this pull request as ready for review October 9, 2023 18:39
@atierian atierian merged commit 6117f76 into swift-sdk-0260 Oct 9, 2023
72 checks passed
@atierian atierian deleted the sdk/integration-tests branch October 9, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants