fix(storage-test): use identity comparison operators not XCTest metho…

…ds (#3278)
aws-amplify · Oct 5, 2023 · 937de0c · 937de0c
1 parent ba2247b
commit 937de0c
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/...Storage/Tests/AWSS3StoragePluginTests/Configuration/S3ClientConfigurationProxyTests.swift b/...Storage/Tests/AWSS3StoragePluginTests/Configuration/S3ClientConfigurationProxyTests.swift
@@ -19,9 +19,7 @@ final class S3ClientConfigurationAccelerateTestCase: XCTestCase {
     /// When: An override is set through `withAccelerate(_:)`
     /// Then: The base configuration is not mutated.
     func testPropertyOverrides() async throws {
-        let baseConfiguration = try await S3Client.S3ClientConfiguration()
-        baseConfiguration.serviceSpecific.accelerate = true
-
+        let baseConfiguration = try await configuration(accelerate: true)
         let sut = try baseConfiguration.withAccelerate(false)
         XCTAssertEqual(sut.serviceSpecific.accelerate, false)
         XCTAssertEqual(baseConfiguration.serviceSpecific.accelerate, true)
@@ -35,7 +33,7 @@ final class S3ClientConfigurationAccelerateTestCase: XCTestCase {
         let baseConfiguration = try await configuration(accelerate: baseAccelerate)
 
         let nilAccelerate = try baseConfiguration.withAccelerate(nil)
-        XCTAssertIdentical(baseConfiguration, nilAccelerate)
+        XCTAssert(baseConfiguration === nilAccelerate)
     }
 
     /// Given: A client configuration.
@@ -46,7 +44,7 @@ final class S3ClientConfigurationAccelerateTestCase: XCTestCase {
         let baseConfiguration = try await configuration(accelerate: baseAccelerate)
 
         let equalAccelerate = try baseConfiguration.withAccelerate(baseAccelerate)
-        XCTAssertIdentical(baseConfiguration, equalAccelerate)
+        XCTAssert(baseConfiguration === equalAccelerate)
     }
 
     /// Given: A client configuration.
@@ -57,7 +55,7 @@ final class S3ClientConfigurationAccelerateTestCase: XCTestCase {
         let baseConfiguration = try await configuration(accelerate: baseAccelerate)
 
         let nonEqualAccelerate = try baseConfiguration.withAccelerate(!baseAccelerate)
-        XCTAssertNotIdentical(baseConfiguration, nonEqualAccelerate)
+        XCTAssert(baseConfiguration !== nonEqualAccelerate)
     }
 
 
@@ -74,7 +72,7 @@ final class S3ClientConfigurationAccelerateTestCase: XCTestCase {
             credentialsProvider: nil,
             endpoint: UUID().uuidString,
             serviceSpecific: serviceSpecific,
-            region: nil,
+            region: "us-east-1",
             regionResolver: nil,
             signingRegion: UUID().uuidString,
             useDualStack: .random(),