fix(@aws-amplify/analytics)!: do not attempt to delete unused endpoints

[iartemiev]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[lgtm-com]

This pull request introduces 1 alert and fixes 1 when merging bdde247 into 31c7199 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

fixed alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request fixes 1 alert when merging dca2a41 into 31c7199 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request fixes 1 alert when merging efde74b into 31c7199 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[codecov]

Codecov Report

Merging #7245 (efde74b) into main (31c7199) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7245      +/-   ##
==========================================
+ Coverage   73.05%   73.11%   +0.06%     
==========================================
  Files         213      213              
  Lines       13379    13342      -37     
  Branches     2521     2615      +94     
==========================================
- Hits         9774     9755      -19     
+ Misses       3439     3392      -47     
- Partials      166      195      +29     

Impacted Files	Coverage Δ
...ges/analytics/src/Providers/AWSPinpointProvider.ts	77.62% <100.00%> (+2.92%)	⬆️
packages/auth/src/OAuth/OAuth.ts	56.11% <0.00%> (ø)
packages/core/src/Credentials.ts	31.51% <0.00%> (ø)
packages/analytics/src/Analytics.ts	63.58% <0.00%> (ø)
packages/datastore/src/sync/index.ts	14.53% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts	24.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts	71.66% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts	33.33% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts	37.50% <0.00%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c7199...b5e053a. Read the comment docs.

[sammartinez]

LGTM 🌮

[manueliglesias]

LGTM

[lgtm-com]

This pull request fixes 1 alert when merging b5e053a into 31c7199 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[elorzafe]

Looks good to me thanks @iartemiev ! 🌮

[joebernard]

This merge seems to have reintroduced an old issue. See #7251 .

[dylan-westbury]

As @joebernard has mentioned, we have had to set our amplify version to a previous as inactive endpoints don't clear and once user reaches 10 they cannot receive any more push notifications.

[GeorgeBellTMH]

Can we please get this and the corresponding change in cli reverted? This is causing all sorts of problems...

[GeorgeBellTMH]

@iartemiev @sammartinez @manueliglesias @elorzafe can we get some idea why this change was made? It is breaking functionality, there is no explanation why it was needed, no ticket it was related to, and there is no response to many complaints about it breaking functionality....can we get some idea of what is being done to fix the issue?

[github-actions]

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.