-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Auth): Allow sending login_hint, lang and nonce on signInWithRedirects #14089
base: main
Are you sure you want to change the base?
feat(Auth): Allow sending login_hint, lang and nonce on signInWithRedirects #14089
Conversation
aea008c
to
4e14f62
Compare
4e14f62
to
0b43c44
Compare
Thanks for opening the PR @Alevale and adding the tests for it. We will review the proposed change internally 👍 |
0b43c44
to
5ea67c1
Compare
5ea67c1
to
9be73c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution! The suggested new parameters make sense! Please take a look at the suggested changes.
9be73c7
to
b9b8f1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty!
Thx guys! |
Guys, should I keep on updating the branch with the latest changes till it's merged? |
Description of changes
This adds support for the login_hint, lang and nonce parameters, which are supported by cognito as of the official documentation https://docs.aws.amazon.com/cognito/latest/developerguide/authorization-endpoint.html
The way to pass them is by adding them as extra options under the input parameters on the
signInWithRedirect
functionIssue #, if available
Adding login_hint would fix #8951
Possible fix by adding nonce #4998
Support lang attribute #14040
Description of how you validated changes
Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.