-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release(required): Amplify JS release #12670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: fix unknown error typo
* chore: comment and remove failing and not need canaries
* chore: Upgrade Jest * Address feedback * Address feedback * Fix issue with required uuid-validate module --------- Co-authored-by: Aaron S <[email protected]>
…ssr_page` tests fix (#12655) fix: Build Sample App Tests and integ_next_auth_authenticator_and_ssr_page tests
…test (#12657) * chore: remove integ_vue_auth_legacy_vue_authenticator test
…ig methods (#12487) * chore(aws-amplify): add inline docs for Amplify configure and getConfig methods * Apply suggestions from code review Co-authored-by: Chris F <[email protected]> --------- Co-authored-by: Chris F <[email protected]>
* fix: dispatch signInWithRedirect failure event * chore: add unit tests * chore: bundle size test * chore: address feedback * chore: remove unknown type
jimblanc
approved these changes
Dec 4, 2023
elorzafe
approved these changes
Dec 5, 2023
reesscot
approved these changes
Dec 5, 2023
david-mcafee
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the assumption that the failing checks will be resolved.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.