test: update signOut unit tests #12561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
commented
Nov 10, 2023
| @@ -96,26 +99,30 @@ async function clientSignOut(cognitoConfig: CognitoUserPoolConfig) { | |||
| } | |||
| } catch (err) { | |||
| // this shouldn't throw | |||
| // TODO(v6): add logger message | |||
| logger.debug( | |||
There was a problem hiding this comment.
Added to address a TODO and facilitate better logic branch testing
cshfang
commented
Nov 10, 2023
| } | ||
| } | ||
|
|
||
| async function globalSignOut(cognitoConfig: CognitoUserPoolConfig) { | ||
| try { | ||
| const tokens = await tokenOrchestrator.getTokenStore().loadTokens(); | ||
| assertAuthTokens(tokens); | ||
| const authTokens = await tokenOrchestrator.getTokenStore().loadTokens(); |
There was a problem hiding this comment.
Just updated variable name here for consistency with clientSignOut function
HuiSF
approved these changes
Nov 14, 2023
israx
approved these changes
Nov 14, 2023
elorzafe
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR updates and adds unit tests for the updated
signOutAPIDescription of how you validated changes
yarn testChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.