feat(inApp): functional dispatchEvent & setConflictHandler APIs #12231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
reviewed
Oct 9, 2023
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/processInAppMessages.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/processInAppMessages.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/processInAppMessages.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/processInAppMessages.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/processInAppMessages.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/helpers.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/helpers.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/helpers.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/helpers.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/helpers.ts
Show resolved
Hide resolved
HuiSF
previously approved these changes
Oct 9, 2023
jimblanc
reviewed
Oct 10, 2023
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/dispatchEvent.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/dispatchEvent.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/dispatchEvent.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/setConflictHandler.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/setConflictHandler.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/setConflictHandler.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/setConflictHandler.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/helpers.ts
Outdated
Show resolved
Hide resolved
This was referenced Oct 10, 2023
jimblanc
approved these changes
Oct 10, 2023
HuiSF
approved these changes
Oct 10, 2023
Samaritan1011001
merged commit f5bcc3a
into
aws-amplify:next/main
23 of 24 checks passed
cshfang
reviewed
Oct 10, 2023
packages/notifications/__tests__/inAppMessaging/providers/pinpoint/apis/dispatchEvent.test.ts
Show resolved
Hide resolved
...es/notifications/__tests__/inAppMessaging/providers/pinpoint/apis/setConflictHandler.test.ts
Show resolved
Hide resolved
...es/notifications/__tests__/inAppMessaging/providers/pinpoint/apis/setConflictHandler.test.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/dispatchEvent.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/apis/setConflictHandler.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/types/inputs.ts
Show resolved
Hide resolved
packages/notifications/src/inAppMessaging/providers/pinpoint/utils/helpers.ts
Show resolved
Hide resolved
Samaritan1011001
added a commit
to Samaritan1011001/amplify-js
that referenced
this pull request
Oct 10, 2023
…amplify#12231) * chore: truncate comments and typo --------- Co-authored-by: Aaron S <[email protected]> Co-authored-by: Jim Blanchard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds helpers, utils and APIs for dispatchEvent and setConflictHandler
Issue #, if available
Description of how you validated changes
Campaign messages were synced using syncMessages API and dispatchEvent API was used to trigger the listeners and result was verified through console logs. After the addition of notifyListeners APIs it can be validated end to end. setConflictHandler was used to set a custom conflict handler for dispatchEvent API to use.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.