fix: Patch paho-mqtt to apply fix for bug when cookies are disabled #10841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1994
to
+2001
| var match = uri.match( | ||
| /^(wss?):\/\/((\[(.+)\])|([^\/]+?))(:(\d+))?(\/.*)$/ | ||
| ); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
There was a problem hiding this comment.
Preferring to keep this consistent with the vendor library implementation.
elorzafe
previously approved these changes
Jan 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #10841 +/- ##
==========================================
- Coverage 85.88% 81.30% -4.58%
==========================================
Files 197 198 +1
Lines 18373 19510 +1137
Branches 3909 4208 +299
==========================================
+ Hits 15779 15862 +83
- Misses 2520 3358 +838
- Partials 74 290 +216
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4 tasks
stocaaro
force-pushed
the
9185-paho-mqtt-patch
branch
4 times, most recently
from
db0657a to
e8d34c5
Compare
Original PR: eclipse-paho/paho.mqtt.javascript#247 Co-authored-by: Sam Dawson <[email protected]>
stocaaro
force-pushed
the
9185-paho-mqtt-patch
branch
from
e8d34c5 to
8f74aea
Compare
jimblanc
approved these changes
Jan 11, 2023
AllanZhengYP
approved these changes
Jan 11, 2023
elorzafe
approved these changes
Jan 11, 2023
This was referenced Jun 20, 2023
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
paho-mqttraises an error breakingamplify-jscustomer experiences when customers have cookies disabled (as detailed in this issue).This change adopts the proposed fix as a patch directly in the PubSub category code to fix the experience.
Issue #, if available
#9185
Description of how you validated changes
The error is reproducible by:
I have verified that without this change, the result is the error:
After the change, my application works as normal allowing subscriptions to be created and published to, with the caveat that it will prompt for login on every reload (no cookies).
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.