Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): fix log levels to have none as the lowest level in the log level enum #3994

Merged

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Oct 23, 2023

Issue #, if available:

Description of changes:

  • having the none log level as the last value in the enum list cause the logs with none level to be logged. this fixes the enum value list to have the none as the lowest index so the compareTo method works as expected.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner October 23, 2023 23:56
@NikaHsn NikaHsn merged commit b56da77 into aws-amplify:feat/logging/cloudwatch Oct 24, 2023
381 of 421 checks passed
khatruong2009 pushed a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants