chore(repo): simplify cw reporting #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove failing step because Cloudwatch reports metric schemas based on unique dimension key/value sets which is a problem since failing step value can change all the time 2. Normalize metric dimension keys by sending blank values. This ensures Cloudwatch reports a single metric schema in the AWS console as opposed to the 30+ different metric schema dimension key values sets from before. 3. Due to changes increased metric_name version to “github_metric_2.0”
fjnoyp
force-pushed
the
feat/simplify-cw-reporting
branch
from
fadef4d to
20498ab
Compare
haverchuck
approved these changes
Oct 17, 2023
Equartey
approved these changes
Oct 18, 2023
Equartey
pushed a commit
that referenced
this pull request
Oct 26, 2023
Equartey
pushed a commit
that referenced
this pull request
Oct 30, 2023
khatruong2009
pushed a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove failing step because Cloudwatch reports metric schemas based on unique dimension key/value sets which is a problem since failing step value can change all the time
Normalize metric dimension keys by sending blank values. This ensures Cloudwatch reports a single metric schema in the AWS console as opposed to the 30+ different metric schema dimension key values sets from before.
Due to changes increased metric_name version to “github_metric_2.0”
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.