Merge branch 'main' into test/state-machine/cleanup

aws-amplify · Oct 25, 2023 · 993bf09 · 993bf09
2 parents f9de098 + 037dce8
commit 993bf09
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/packages/analytics/amplify_analytics_pinpoint/example/integration_test/no_unauth_test.dart b/packages/analytics/amplify_analytics_pinpoint/example/integration_test/no_unauth_test.dart
@@ -14,7 +14,9 @@ import 'utils/mock_secure_storage.dart';
 void main() {
   IntegrationTestWidgetsFlutterBinding.ensureInitialized();
 
-  group('unathenticated access restricted', () {
+  group(
+      'Amplify.configure should complete even when unauthenticated access is disabled.',
+      () {
     tearDown(Amplify.reset);
 
     for (final environmentName in const [
@@ -34,7 +36,7 @@ void main() {
         ]);
         await expectLater(
           Amplify.configure(amplifyEnvironments[environmentName]!),
-          throwsA(isA<UnknownException>()),
+          completes,
         );
       });
     }

diff --git a/packages/analytics/amplify_analytics_pinpoint_dart/lib/src/analytics_plugin_impl.dart b/packages/analytics/amplify_analytics_pinpoint_dart/lib/src/analytics_plugin_impl.dart
@@ -128,7 +128,11 @@ class AmplifyAnalyticsPinpointDart extends AnalyticsPluginInterface {
     _endpointClient = analyticsClient.endpointClient;
     _eventClient = analyticsClient.eventClient;
 
-    await _endpointClient.updateEndpoint();
+    try {
+      await _endpointClient.updateEndpoint();
+    } on Exception catch (e) {
+      _logger.warn('Could not update endpoint: $e');
+    }
 
     _sessionManager = SessionManager(
       fixedEndpointId: _endpointClient.fixedEndpointId,

diff --git a/...lify_analytics_pinpoint_dart/lib/src/impl/analytics_client/event_client/event_client.dart b/...lify_analytics_pinpoint_dart/lib/src/impl/analytics_client/event_client/event_client.dart
@@ -204,6 +204,11 @@ class EventClient implements Closeable {
       // Due to no internet or unable to reach server.
       // These exceptions are always retryable.
       eventsToDelete.clear();
+    } on AuthException {
+      // AuthException indicates request did not complete
+      // Due to Authentication error.
+      // These exceptions are always retryable.
+      eventsToDelete.clear();
     } on SmithyHttpException catch (e) {
       if (e.statusCode != null && _isRetryable(e.statusCode)) {
         eventsToDelete.removeWhere((eventId, _) {