fix: correctly remove file extension on types import path #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
previously approved these changes
Oct 13, 2023
palpatim
reviewed
Oct 13, 2023
| @@ -36,7 +36,7 @@ export class GraphQLStatementsFormatter { | |||
| this.lintOverrides = []; | |||
| this.headerComments = []; | |||
| this.typesPath = typesPath | |||
| ? typesPath.replace(/.ts/i, '') | |||
| ? typesPath.replace(/\.[^.]+$/, '') // remove file extensions | |||
There was a problem hiding this comment.
Why not use Node's path module for this? path.parse(typesPath).ext will give you the extension to remove; .name will give the name exclusive of the extension, .dir + .name seems like what you want here.
There was a problem hiding this comment.
I thought about this and thought the regex would be cleaner. But looking at it again path.parse would be more error resistant.
palpatim
approved these changes
Oct 16, 2023
alharris-at
approved these changes
Oct 16, 2023
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Correctly remove file extensions on types import path. See #741 for details.
Issue #, if available
Resolves: #741
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.