Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Amplify Android Lazy Types and Custom Selection Set #699

Merged
merged 38 commits into from
Oct 4, 2023

Conversation

tylerjroach
Copy link
Member

@tylerjroach tylerjroach commented Sep 14, 2023

Description of changes

Amplify Android will now support lazy loading and custom selection set with the existing cli.json generatemodelsforlazyloadandcustomselectionset flag already in use by iOS.

Issue #, if available

Amplify Android Work: https://github.com/aws-amplify/amplify-android/tree/tjroach/custom-selection-set
Documentation: TBD

Description of how you validated changes

The newly generated models have been tested in an Amplify Android feature branch.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Breaking changes to existing customers are released behind a feature flag or major version update
  • Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach
Copy link
Member Author

Closing until an addition to check if DataStore is enabled. Since lazy and custom select set support is only being added to the Api category on Android now, if data store is being used (even if the generatemodelsforlazyloadandcustomselectionset cli flag is enabled), the models should not generate with lazy support.

@tylerjroach
Copy link
Member Author

Closing until the above comment is resolved.

@tylerjroach tylerjroach reopened this Sep 18, 2023
lawmicha
lawmicha previously approved these changes Sep 29, 2023
@tylerjroach tylerjroach marked this pull request as ready for review October 3, 2023 14:17
@tylerjroach tylerjroach requested review from a team as code owners October 3, 2023 14:17
lawmicha
lawmicha previously approved these changes Oct 3, 2023
@tylerjroach tylerjroach dismissed stale reviews from dpilch and lawmicha via a0de407 October 4, 2023 15:42
@alharris-at alharris-at merged commit 6e3de3c into main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants