-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Amplify Android Lazy Types and Custom Selection Set #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/appsync-modelgen-plugin/src/preset.ts
Closing until an addition to check if DataStore is enabled. Since lazy and custom select set support is only being added to the Api category on Android now, if data store is being used (even if the |
Closing until the above comment is resolved. |
lawmicha
reviewed
Sep 15, 2023
packages/appsync-modelgen-plugin/src/languages/java-declaration-block.ts
Show resolved
Hide resolved
packages/appsync-modelgen-plugin/src/visitors/appsync-java-visitor.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/appsync-modelgen-plugin/src/visitors/appsync-java-visitor.ts
…l-refactor refactor join model preset code
lawmicha
reviewed
Sep 29, 2023
lawmicha
reviewed
Sep 29, 2023
packages/appsync-modelgen-plugin/src/visitors/appsync-java-visitor.ts
Outdated
Show resolved
Hide resolved
lawmicha
reviewed
Sep 29, 2023
lawmicha
reviewed
Sep 29, 2023
lawmicha
previously approved these changes
Sep 29, 2023
dpilch
reviewed
Oct 2, 2023
lawmicha
previously approved these changes
Oct 3, 2023
dpilch
previously approved these changes
Oct 4, 2023
packages/appsync-modelgen-plugin/src/visitors/appsync-java-visitor.ts
Outdated
Show resolved
Hide resolved
…itor.ts Co-authored-by: Dane Pilcher <[email protected]>
dpilch
approved these changes
Oct 4, 2023
lawmicha
approved these changes
Oct 4, 2023
6 tasks
alharris-at
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Amplify Android will now support lazy loading and custom selection set with the existing cli.json
generatemodelsforlazyloadandcustomselectionset
flag already in use by iOS.Issue #, if available
Amplify Android Work: https://github.com/aws-amplify/amplify-android/tree/tjroach/custom-selection-set
Documentation: TBD
Description of how you validated changes
The newly generated models have been tested in an Amplify Android feature branch.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.