chore: refactor command/models.js into independent functions, add jsdoc type annotations #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oc type annotations
alharris-at
changed the title
dpilch
approved these changes
Sep 12, 2023
alharris-at
added a commit
that referenced
this pull request
Sep 12, 2023
…oc type annotations (#693)
alharris-at
added a commit
that referenced
this pull request
Sep 13, 2023
…degen models without an initialized amplify app (#698) * feat: use default directive definitions if outside amplify project (#686) * chore: refactor command/models.js into independent functions, add jsdoc type annotations (#693) * feat: support modelgen without an amplify backend (#694) * feat: support modelgen without an amplify backend * chore: add unit tests for new utils * chore: add tests to confirm that tests for detached projects return the right files * chore: add additional unit tests for uninitialized backend states * feat: add e2e tests for modelgen in an uninitialized project (#696) * feat: add e2e tests for modelgen in an uninitialized project * fix: expecting to reject failed in CI, trying to just use a try-catch instead --------- Co-authored-by: Dane Pilcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This refactor should make the functional change to support modelgen without an amplify initialized backend a bit more straightforward, and the type annotations have helped me in the refactor. There are no functional changes, and I'm relying on unit tests to verify that fact.
Issue #, if available
N/A
Description of how you validated changes
Unit Tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.