fix: reduce memory pressure while uploading files #13718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is a partial revert of https://github.com/aws-amplify/amplify-cli/pull/13493/files which caused #13681 .
I.e. using
s3.upload
API for all uploads puts a memory pressure due to aws/aws-sdk-js#2552 .This PR changes file uploading logic to buffer all files below 5mb in memory. This partially restoring previous behavior but avoiding full revert to
s3.putObject
API call which doesn't have retries.Issue #, if available
#13681
Description of how you validated changes
PR checks and E2E tests.
Manual verification on
t2.nano
with sample test project whereENOMEM
has been reproduced.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.