-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve issues with graphiql explorer #13555
Conversation
fix: implement a new jwt library (jose) for signing and validating jwts fix: remove unsupported jsonwebtoken fix: graphiql explorer implementation chore: bump package versions
Hi @afnx - sorry for the delay! I just pinged the team about this. Thanks for putting together the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your contribution is really appreciated. Posted a few comments/questions. Also can you rebase your PR with the base branch? Thanks.
@phani-srikar Thank you for reviewing the changes. I replied to your questions and rebased the PR. |
Hi @phani-srikar @mauerbac can you ping the team for the second review? |
There are 2 CI jobs that are failing on the PR:
It might be easier for us to pull these changes in into a new branch in the parent repo and help you fix these things since you don't have visibility into the errors. Let us know. |
Hi @afnx, sorry for the delay. I will work on getting the CI checks passing for this change. |
fix: implement a new jwt library (jose) for signing and validating jwts
fix: remove unsupported jsonwebtoken
fix: graphiql explorer implementation
chore: bump package versions
Description of changes
The GraphiQL IDE was not working because of a error appeared on the browser console (shown below). After investigating, I found that the issue was with JWT signing, which was caused by updates to some packages. The original library, jsonwebtoken, wasn't working correctly anymore, causing errors. To fix this, I switched to using the jose library, a well-known alternative. I also made adjustments to the GraphiQL IDE implementation to make it work with the changes.
Uncaught (in promise) Error: Error when generating OIDC token: invalid 'instanceof' operand g
Issue #, if available
aws-amplify/amplify-category-api#1269, aws-amplify/amplify-category-api#1369
Description of how you validated changes
I edited the existing tests to match the new jwt signing implementation.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.