fix: parse cognito pools with service role #13365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awsluja
reviewed
Oct 24, 2023
packages/amplify-provider-awscloudformation/src/__tests__/aws-utils/IdentityPoolService.test.ts
Outdated
Show resolved
Hide resolved
sobolk
previously approved these changes
Oct 25, 2023
sobolk
previously approved these changes
Oct 25, 2023
sobolk
approved these changes
Oct 25, 2023
awsluja
approved these changes
Oct 25, 2023
|
Failing e2e test is a regression the UI Builder service rolled out to Manually verified this is working in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Correctly parse Cognito user/identity pools with
service-roleprepended (e.g.arn:aws:iam::<account-id>:role/service-role/roleName).Issue #, if available
#13345
Description of how you validated changes
Manually with
amplify-dev import authand Cognito user/identity pools withservice-role.Updated unit tests and added IAM regex validation for roles.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.